Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A simple addition of dynamic_ncols=True #3242

Merged
merged 2 commits into from
Mar 6, 2024
Merged

A simple addition of dynamic_ncols=True #3242

merged 2 commits into from
Mar 6, 2024

Conversation

chujiezheng
Copy link
Contributor

@chujiezheng chujiezheng commented Mar 6, 2024

It can be useful when using tmux where the window size may change.

Copy link
Collaborator

@simon-mo simon-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@simon-mo simon-mo enabled auto-merge (squash) March 6, 2024 21:59
@simon-mo simon-mo disabled auto-merge March 6, 2024 21:59
@simon-mo simon-mo enabled auto-merge (squash) March 6, 2024 21:59
@simon-mo simon-mo merged commit 4cb3b92 into vllm-project:main Mar 6, 2024
21 of 23 checks passed
dtransposed pushed a commit to afeldman-nm/vllm that referenced this pull request Mar 26, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants