Fixes the misuse/mixuse of time.time()/time.monotonic() #3220
+7
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed that there's some mixuse of
time.time()
andtime.monotonic()
, however, these two function cannot be used to subtract to compute the duration, e.g.,self.metrics.time_in_queue = time - self.metrics.arrival_time
.The
time.time()
is preferred as it denotes the timepoint of events, e.g.,arrive
,scheduled
, andfinished
.After this PR, only the
StatLogger
usestime.monotonic()
to decide when to print a log message.