Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code-revision config argument for Hugging Face Hub #2892

Merged
merged 2 commits into from
Feb 18, 2024

Conversation

mbm-ai
Copy link
Contributor

@mbm-ai mbm-ai commented Feb 16, 2024

Introduce the code-revision argument to facilitate the selection of a specific revision when fetching model code from the Hugging Face Hub. Prior to this enhancement, the default behavior was to always download the latest version which may not always be intended. Users can now specify a revision to ensure consistent model code retrieval. The default behavior remains unchanged, automatically fetching the latest version when the argument is not provided.

Introduce the `code-revision` argument to facilitate the selection of a specific revision when fetching model code from the Hugging Face Hub. Prior to this enhancement, the default behavior was to always download the latest version which may not always be intended. Users can now specify a revision to ensure consistent model code retrieval. The default behavior remains unchanged, automatically fetching the latest version when the argument is not provided.

Run yapf and ruff
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution!

@zhuohan123 zhuohan123 merged commit 786b7f1 into vllm-project:main Feb 18, 2024
19 checks passed
@mbm-ai mbm-ai deleted the args--code-revision branch February 18, 2024 15:06
xjpang pushed a commit to xjpang/vllm that referenced this pull request Feb 22, 2024
xjpang pushed a commit to xjpang/vllm that referenced this pull request Mar 4, 2024
Temirulan pushed a commit to Temirulan/vllm-whisper that referenced this pull request Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants