-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix AttributeError: MixtralModel object has no attribute org_vocab_size. #2875
Conversation
You are right, this is indeed broken at the moment! There seems to be some divergence on how things are working for Mistral vs. Mixtral (Mixtral has |
For this, Mistral has the correct logic and Mixtral should follow it exactly. |
Let me try to update that @Pernekhan do you mind if I push to your PR to update it? |
Unfortunately I couldn't push to this PR, so made a new one including your commit @Pernekhan :) |
* Fix AttributeError: MixtralModel object has no attribute org_vocab_size. * Make LoRA logic for Mistral and Mixtral the same --------- Co-authored-by: Pernekhan Utemuratov <[email protected]>
…vllm-project#2880) * Fix AttributeError: MixtralModel object has no attribute org_vocab_size. * Make LoRA logic for Mistral and Mixtral the same --------- Co-authored-by: Pernekhan Utemuratov <[email protected]>
…vllm-project#2880) * Fix AttributeError: MixtralModel object has no attribute org_vocab_size. * Make LoRA logic for Mistral and Mixtral the same --------- Co-authored-by: Pernekhan Utemuratov <[email protected]>
…vllm-project#2880) * Fix AttributeError: MixtralModel object has no attribute org_vocab_size. * Make LoRA logic for Mistral and Mixtral the same --------- Co-authored-by: Pernekhan Utemuratov <[email protected]>
…vllm-project#2880) * Fix AttributeError: MixtralModel object has no attribute org_vocab_size. * Make LoRA logic for Mistral and Mixtral the same --------- Co-authored-by: Pernekhan Utemuratov <[email protected]>
Mixtral cannot start because of this error:
Related PR: #2831