Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usage Stats Collection #2852
Usage Stats Collection #2852
Changes from 26 commits
e0e1386
739f4a1
c33b4cc
b74e3a6
c988e07
88c5187
85adbab
33c9dff
ad609f0
8a2f18a
8e9e5be
f537692
0f1ba7f
abc3948
ec54145
f84ccaa
b08ba86
83ff459
73b689a
86da72f
9c9a188
d2f84cf
4e888e0
eb48061
0684c06
8e9890e
5cf652a
d910b05
8cf264b
93b8773
fe39b84
fc6e374
ab23171
686c84a
877eb78
bc89a66
36fd304
e54f15b
4e35b3b
a1597fb
c580797
84353d4
f2e69fc
4e19967
f327f3c
d9c8a44
59f0f10
f34259a
30df77c
60b652b
be91bab
4f04743
f4bf862
6b968db
2006788
db715c8
2c1e557
42e66b8
a4e5742
9652830
ba63b44
58fb78d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the package can be installed in many different ways/places, it might make more sense to have one clear path such as in the user's directory for documentation. Maybe
~/.config/vllm/usage_stats.json
or~/.cache/vllm/usage_stats.json
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yes! @yhu422 please do
~/.config/vllm/usage_stats.json
and respectXDG_CONFIG_HOME
env var.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if it makes more sense to get the model architecture vs the model name?
E.g. its probably more useful to know its the Llama architecture with size X over the name of the string for tracking purposes. Otherwise youll have to do this on the backend + it may not be recoverable for local models
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+100
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be good to get the type of CPU as well, such as it's product name so you can be aware of what ISA extensions are available for performance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1!