-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Perform snapshot based model result test #2844
Conversation
Hi @simon-mo , what's the status on this PR? I updated it a bit based on the current master (PR here) I do observe different outputs for vllm vs HF for Deci/DeciLM-7b. Example below: prompt: HF: vLLM: |
@sahilsuneja1, thanks! I don't have bandwidth to work on this PR at the moment so if you can create another PR based on your fixes that would be awesome. As you can see the primary issue in the CI testing is that it runs out of memory even with |
Got it, thanks @simon-mo, will do. |
Found the run history: https://buildkite.com/vllm/ci/builds?branch=simon-mo%3Amodels-snapshot-testing |
Actually I'm going to close this PR because I think snapshot testing is still too brittle (need to update it on model by model basis). We should just get A100 machine to run these tests. |
OK, I'll close the update PR as well |
sorry about the back and forth! |
No worries! |
This PR implement snapshot based testing in CI such that the model output in float32 matches exactly as of Huggingface version.