Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit packed params in preparation for more LoRA support #2843

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

pcmoritz
Copy link
Collaborator

This PR is in preparation for #2831, to make it easier to implement LoRA for different models without too much code duplication with model weight loading.

It factors out which parameters are packed together and makes it part of the model class for the models that use parameter packing.

@simon-mo
Copy link
Collaborator

@pcmoritz can you take a look at #2637 which I think we should merge first

@simon-mo
Copy link
Collaborator

I think they are overall orthogonal but it will cause conflict for you once #2637 is merged.

@pcmoritz
Copy link
Collaborator Author

pcmoritz commented Feb 13, 2024

Yes, let's merge #2637 first -- I just wanted to make sure we have a path forward here to unify the LoRA handling and the weight loading :)

@pcmoritz pcmoritz mentioned this pull request Feb 14, 2024
12 tasks
Copy link

This pull request has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions bot added the stale label Oct 30, 2024
Copy link

mergify bot commented Oct 30, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. @pcmoritz please rebase it. https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Oct 30, 2024
@github-actions github-actions bot added unstale and removed stale labels Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants