Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Speculative decoding 2/9] Multi-step worker for draft model #2424

Merged
merged 4 commits into from
Jan 22, 2024

Conversation

cadedaniel
Copy link
Collaborator

@cadedaniel cadedaniel commented Jan 12, 2024

This PR implements the worker which contains the draft model in speculative decoding. See #2188 and the speculative decoding open sourcing plan for more info. This is contributed by Anyscale.

The MultiStepWorker extends the vanilla Worker class and augments execute_model to invoke the underlying model multiple times in a single scheduling iteration. To work end-to-end in vLLM, it requires that the scheduler support scheduling >1 token per scheduling iteration. That will come in a future PR.

@cadedaniel cadedaniel changed the title [Speculative decoding 2/9] Multi-step worker for draft model [Draft] [Speculative decoding 2/9] Multi-step worker for draft model Jan 12, 2024
@cadedaniel cadedaniel marked this pull request as ready for review January 17, 2024 22:50
@cadedaniel cadedaniel changed the title [Draft] [Speculative decoding 2/9] Multi-step worker for draft model [Speculative decoding 2/9] Multi-step worker for draft model Jan 17, 2024
Copy link
Collaborator

@LiuXiaoxuanPKU LiuXiaoxuanPKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants