Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MPTConfig #1529

Merged
merged 5 commits into from
Nov 1, 2023
Merged

Remove MPTConfig #1529

merged 5 commits into from
Nov 1, 2023

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Oct 31, 2023

Now that MPT is a regular model in HF Transformers, we can remove our own MPTConfig.

NOTE: After this PR, using MPT with trust_remote_code=True will raise an error. trust_remote_code=True is also supported.

TODO: Do the same thing for Falcon.

Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@WoosukKwon WoosukKwon merged commit 1fe0990 into main Nov 1, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the remove-mpt-config branch November 1, 2023 22:29
@megha95 megha95 mentioned this pull request Nov 15, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants