Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bias in InternLM #1501

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Fix bias in InternLM #1501

merged 1 commit into from
Oct 29, 2023

Conversation

WoosukKwon
Copy link
Collaborator

Fixes #1411

bias in InternLM is not always True. It should be config.bias.

@WoosukKwon WoosukKwon mentioned this pull request Oct 29, 2023
Closed
zhuohan123
zhuohan123 approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@zhuohan123 zhuohan123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@WoosukKwon WoosukKwon merged commit aa9af07 into main Oct 29, 2023
2 checks passed
@WoosukKwon WoosukKwon deleted the fix-bias branch October 29, 2023 23:24
@WoosukKwon WoosukKwon mentioned this pull request Nov 7, 2023
Closed
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
@WoosukKwon
Fix bias in InternLM (vllm-project#1501)
f05fa71
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
@WoosukKwon
Fix bias in InternLM (vllm-project#1501)
5651091
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhuohan123 zhuohan123 zhuohan123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InternLM 20B Support
2 participants
@WoosukKwon @zhuohan123