Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin dependency versions #1429

Merged
merged 2 commits into from
Oct 21, 2023
Merged

Pin dependency versions #1429

merged 2 commits into from
Oct 21, 2023

Conversation

thiagosalvatore
Copy link
Contributor

FastAPI released a new version last week that conflicts with typing-extensions and typing-inspect versions that are needed to run correctly on docker (at least for MPT models).

In order to make vLLM work properly I needed to create a dockerfile like this

FROM nvcr.io/nvidia/pytorch:22.12-py3

RUN pip uninstall torch -y
RUN pip install vllm

RUN pip install typing-inspect==0.8.0 typing_extensions==4.5.0 fastapi==0.103.2

I saw several issues reporting the same behavior so I decided to open this PR pinning the versions that we currently need to make everything work properly until we can make sure that the entire code works properly with the newest versions of typing extensions, typing inspect and fastapi.

@WoosukKwon WoosukKwon self-requested a review October 21, 2023 17:50
@WoosukKwon
Copy link
Collaborator

Hi @thiagosalvatore, thanks for bringing this up! It seems a more fundamental reason for the error is the pydantic==1.10.2 installed in the NVIDIA PyTorch image. I believe fixing the version of pydantic to 1.10.13 would be a better solution.

Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR!

@WoosukKwon WoosukKwon merged commit bf31d36 into vllm-project:main Oct 21, 2023
2 checks passed
skrider pushed a commit to skrider/vllm that referenced this pull request Oct 27, 2023
hongxiayang pushed a commit to hongxiayang/vllm that referenced this pull request Feb 13, 2024
sjchoi1 pushed a commit to casys-kaist-internal/vllm that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants