[6/N] torch.compile rollout to users #10437
Conversation
Signed-off-by: youkaichao <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: youkaichao <[email protected]>
| @@ -868,6 +869,16 @@ def add_cli_args(parser: FlexibleArgumentParser) -> FlexibleArgumentParser: | |||
| help="Override or set the pooling method in the embedding model. " | |||
| "e.g. {\"pooling_type\": \"mean\", \"normalize\": false}.'") | |||
|
|
|||
| parser.add_argument('--compilation-config', | |||
| '-O', | |||
There was a problem hiding this comment.
I want to mimic the convention of traditional compiler, -O 3 is the most optimized level.
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
youkaichao
requested review from
WoosukKwon,
robertgshaw2-neuralmagic,
njhill,
ywang96,
comaniac,
alexm-neuralmagic and
zhuohan123
as code owners
youkaichao
changed the title
| 'interpreted as the optimization level.\n' | ||
| 'NOTE: level 0 is the default level without ' | ||
| 'any optimization. level 1 and 2 are for internal ' | ||
| 'testing only. level 3 is the recommended level ' |
There was a problem hiding this comment.
Maybe add that this (levels 1 and 2) could change in the future - if we actually have multiple optimization levels, we can use O1 and O2 and move the internal levels somewhere else
There was a problem hiding this comment.
our optimization is actually not well graded as levels. they appear as complicated configs. I would keep only levels 0/1/2/3 , and recommend using 3 for users.
the user interface:
command line:
short:
-O 0/1/2/3long:
--compilation-config json_stringvllm.LLM:users can construct
CompilationConfigobject directly, and passcompilation_config=obj.the first roll out will only roll out 3 levels, more fine-grained control will come later as we stabilize them.
documentation on how to use and the design doc will come later.