Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Model] Remove redundant softmax when using PoolingType.STEP #10415

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

Maybewuss
Copy link
Contributor

@Maybewuss Maybewuss commented Nov 18, 2024

Whether to enable softmax can be controlled by the softmax parameter when initializing Pooler.

https://github.com/vllm-project/vllm/blob/main/vllm/model_executor/layers/pooler.py#L143

The softmax here is unnecessary.

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@Maybewuss Maybewuss changed the title Remove redundant softmax when using PoolingType.STEP [Model]Remove redundant softmax when using PoolingType.STEP Nov 18, 2024
@Maybewuss Maybewuss changed the title [Model]Remove redundant softmax when using PoolingType.STEP [Model] Remove redundant softmax when using PoolingType.STEP Nov 18, 2024
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 18, 2024 08:54
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 18, 2024
@DarkLight1337 DarkLight1337 merged commit 01aae1c into vllm-project:main Nov 18, 2024
63 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants