Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Fix unable to load some models #10312

Merged
merged 18 commits into from
Nov 15, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 14, 2024

This PR fixes more models broken by #10205 and/or #10304.

I have also added tests for check that each model can be initialized using dummy format.

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 14, 2024
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 marked this pull request as draft November 14, 2024 03:20
@mergify mergify bot added documentation Improvements or additions to documentation ci/build labels Nov 14, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 removed the ready ONLY add when PR is ready to merge/full CI is needed label Nov 14, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Nov 14, 2024

After overriding the HF text config with

{
    "num_layers": 1,
    "num_hidden_layers": 1,
    "num_experts": 2,
    "num_experts_per_tok": 2,
    "num_local_experts": 2,
}

I can even load Snowflake/snowflake-arctic-instruct model (originally with 479B parameters) in a single A10.

Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@mergify mergify bot added the frontend label Nov 14, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fix unable to load more multimodal models [Bugfix] Fix unable to load more models Nov 14, 2024
@DarkLight1337 DarkLight1337 changed the title [Bugfix] Fix unable to load more models [Bugfix] Fix unable to load some models Nov 14, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 14, 2024 10:17
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 14, 2024
@DarkLight1337
Copy link
Member Author

The tests pass locally now!

Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 marked this pull request as draft November 14, 2024 12:45
auto-merge was automatically disabled November 14, 2024 12:45

Pull request was converted to draft

Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337 DarkLight1337 added the release-blocker This PR/issue blocks the next release, therefore deserves highest priority label Nov 14, 2024
@khluu khluu marked this pull request as ready for review November 14, 2024 19:31
@DarkLight1337 DarkLight1337 added ready ONLY add when PR is ready to merge/full CI is needed and removed ready ONLY add when PR is ready to merge/full CI is needed labels Nov 14, 2024
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 14, 2024 22:00
@youkaichao youkaichao merged commit 972112d into vllm-project:main Nov 15, 2024
71 of 74 checks passed
@DarkLight1337 DarkLight1337 deleted the fix-mm branch November 15, 2024 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation frontend ready ONLY add when PR is ready to merge/full CI is needed release-blocker This PR/issue blocks the next release, therefore deserves highest priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants