Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Fix CI tests on V1 engine #10272

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[V1] Fix CI tests on V1 engine #10272

merged 2 commits into from
Nov 13, 2024

Conversation

WoosukKwon
Copy link
Collaborator

@WoosukKwon WoosukKwon commented Nov 12, 2024 •
edited
Loading

This PR fixes the CI tests broken after #10245

@WoosukKwon
[V1] Fix CI tests
09340aa 
Signed-off-by: Woosuk Kwon <[email protected]>
@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@khluu khluu added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 12, 2024
@ywang96 ywang96 enabled auto-merge (squash) November 12, 2024 23:20
@WoosukKwon
Handle abort
1ec1494 
Signed-off-by: Woosuk Kwon <[email protected]>
@ywang96 ywang96 mentioned this pull request Nov 12, 2024
Merged
@khluu khluu enabled auto-merge (squash) November 13, 2024 00:00
@WoosukKwon WoosukKwon merged commit 112fa0b into main Nov 13, 2024
15 of 29 checks passed
@WoosukKwon WoosukKwon deleted the v1-fix-ci branch November 13, 2024 00:17
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
@WoosukKwon @rickyyx
[V1] Fix CI tests on V1 engine (vllm-project#10272)
2413750 
Signed-off-by: Woosuk Kwon <[email protected]>
omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 14, 2024
@WoosukKwon @omer-dayan
[V1] Fix CI tests on V1 engine (vllm-project#10272)
fda596b 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: OmerD <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@WoosukKwon @sumitd2
[V1] Fix CI tests on V1 engine (vllm-project#10272)
53bd9a5 
Signed-off-by: Woosuk Kwon <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 approved these changes

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WoosukKwon @ywang96 @khluu