[misc] improve cloudpickle registration and tests #10202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: youkaichao <[email protected]>
|
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: youkaichao <[email protected]>
youkaichao
commented
Nov 10, 2024
| @@ -161,9 +171,8 @@ def iter_params(self, model_name: str): | |||
| "facebook/opt-iml-max-1.3b": PPTestSettings.fast(), | |||
| "OrionStarAI/Orion-14B-Chat": PPTestSettings.fast(trust_remote_code=True), | |||
| "microsoft/phi-2": PPTestSettings.fast(), | |||
| "microsoft/Phi-3-mini-4k-instruct": PPTestSettings.detailed(trust_remote_code=True, multi_node_only=True), # noqa: E501 | |||
| "microsoft/Phi-3.5-MoE-instruct": PPTestSettings.detailed(trust_remote_code=True, multi_node_only=True, load_format="dummy", hf_overrides='{"num_hidden_layers": 4, "hidden_size": 512, "intermediate_size": 800, "num_attention_heads": 4, "num_key_value_heads": 1}'), # noqa: E501 | |||
There was a problem hiding this comment.
test a model with a point in its name, previously this model is not tested in the ci.
youkaichao
commented
Nov 10, 2024
| @@ -161,9 +171,8 @@ def iter_params(self, model_name: str): | |||
| "facebook/opt-iml-max-1.3b": PPTestSettings.fast(), | |||
| "OrionStarAI/Orion-14B-Chat": PPTestSettings.fast(trust_remote_code=True), | |||
| "microsoft/phi-2": PPTestSettings.fast(), | |||
| "microsoft/Phi-3-mini-4k-instruct": PPTestSettings.detailed(trust_remote_code=True, multi_node_only=True), # noqa: E501 | |||
| "microsoft/Phi-3.5-MoE-instruct": PPTestSettings.detailed(trust_remote_code=True, multi_node_only=True, load_format="dummy", hf_overrides='{"num_hidden_layers": 4, "hidden_size": 512, "intermediate_size": 800, "num_attention_heads": 4, "num_key_value_heads": 1}'), # noqa: E501 | |||
There was a problem hiding this comment.
thanks to @DarkLight1337 adding the hf_overrides recently.
youkaichao
changed the title
DarkLight1337
approved these changes
Nov 10, 2024
github-actions
bot
added
the
ready
|
Thanks @youkaichao |
jeejeelee
pushed a commit
to jeejeelee/vllm
that referenced
this pull request
Nov 11, 2024
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Jee Jee Li <[email protected]>
rickyyx
pushed a commit
to rickyyx/vllm
that referenced
this pull request
Nov 13, 2024
Signed-off-by: youkaichao <[email protected]>
omer-dayan
pushed a commit
to omer-dayan/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: youkaichao <[email protected]> Signed-off-by: OmerD <[email protected]>
sumitd2
pushed a commit
to sumitd2/vllm
that referenced
this pull request
Nov 14, 2024
Signed-off-by: youkaichao <[email protected]> Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improves over #6751
config is the only custom class we pass across processes, and we can move the function call into
get_config, where the first import oftransformers_moduleshappen.I use
cloudpickleto serialize the wholeVllmConfigrather than the singleModelConfig, so that even if people movehf_configoutside ofModelConfig, the code can still work.Also added some example code for when
transformers_moduleswill be available.