Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[doc] explaining the integration with huggingface #10173

Merged
merged 15 commits into from
Nov 9, 2024
Merged

[doc] explaining the integration with huggingface #10173

merged 15 commits into from
Nov 9, 2024

Conversation

youkaichao
Copy link
Member

No description provided.

@youkaichao
add docs
d818226 
Signed-off-by: youkaichao <[email protected]>
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 9, 2024
russellb
russellb reviewed Nov 9, 2024
View reviewed changes
Copy link
Collaborator

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you just started and this is a draft. I noticed one small thing while reading what was here so far.

docs/source/design/huggingface_transformers.rst Outdated Show resolved Hide resolved
@youkaichao
finish
38b710b 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
typo
9cae1c5 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

this doc is mainly the outcome of investigation by @CRZbulabula

@youkaichao
anonymous link
db5d7ed 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
fix
ae4e31e 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
add
3ff04d5 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
gpt polish
3779807 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
fix format?
785b030 
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao changed the title [draft] docs for explaining the integration with huggingface [doc] explaining the integration with huggingface Nov 9, 2024
DarkLight1337
DarkLight1337 approved these changes Nov 9, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed explanation!

ywang96
ywang96 reviewed Nov 9, 2024
View reviewed changes
Copy link
Member

@ywang96 ywang96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great and we have definitely been asked a lot about how model configuration works on vLLM. I left some comments and PTAL!

docs/source/design/huggingface_integration.rst Outdated Show resolved Hide resolved
docs/source/design/huggingface_integration.rst Outdated Show resolved Hide resolved
docs/source/design/huggingface_integration.rst Outdated Show resolved Hide resolved
docs/source/design/huggingface_integration.rst Show resolved Hide resolved
@youkaichao
fix
9d81d85 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
use qwen
05f3374 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
bold
2de7a78 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
bold
4b70e1a 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
polish
ec0e623 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
Copy link
Member Author

@ywang96 thanks for the great review and suggestions!

@youkaichao
fix link
43c2910 
Signed-off-by: youkaichao <[email protected]>
@youkaichao
fix link
20ecbf7 
Signed-off-by: youkaichao <[email protected]>
@youkaichao youkaichao merged commit 8a4358e into vllm-project:main Nov 9, 2024
10 of 13 checks passed
@youkaichao youkaichao deleted the explain_hf branch November 9, 2024 09:02
@russellb
Copy link
Collaborator

russellb commented Nov 9, 2024

Great job on this doc!

omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 10, 2024
@youkaichao @omer-dayan
[doc] explaining the integration with huggingface (vllm-project#10173)
b69d8a2 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: OmerD <[email protected]>
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@youkaichao @JC1DA
[doc] explaining the integration with huggingface (vllm-project#10173)
01b7daa 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
@youkaichao @jeejeelee
[doc] explaining the integration with huggingface (vllm-project#10173)
58d3bd0 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
@youkaichao @rickyyx
[doc] explaining the integration with huggingface (vllm-project#10173)
bac7549 
Signed-off-by: youkaichao <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@youkaichao @sumitd2
[doc] explaining the integration with huggingface (vllm-project#10173)
752b6d3 
Signed-off-by: youkaichao <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywang96 ywang96 ywang96 left review comments

@russellb russellb russellb left review comments

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@youkaichao @russellb @DarkLight1337 @ywang96