Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Split up models tests #10069

Merged
merged 13 commits into from
Nov 9, 2024
Merged

[CI/Build] Split up models tests #10069

merged 13 commits into from
Nov 9, 2024

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Nov 6, 2024

To reduce the impact of flakiness (e.g. connection failures), this PR splits up the model tests into groups.

I have also fixed VLM test failures that were introduced by #8346 and #9983.

Copy link

github-actions bot commented Nov 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 6, 2024
@DarkLight1337
Copy link
Member Author

It looks like sharding doesn't work over parameter combinations.

@DarkLight1337 DarkLight1337 marked this pull request as draft November 6, 2024 08:04
@DarkLight1337 DarkLight1337 marked this pull request as ready for review November 9, 2024 08:17
@DarkLight1337 DarkLight1337 changed the title [CI/Build] Shard models tests [CI/Build] Split up models tests Nov 9, 2024
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 9, 2024
Signed-off-by: DarkLight1337 <[email protected]>
@DarkLight1337
Copy link
Member Author

Would be great if we could get this in before the next nightly!

Copy link

mergify bot commented Nov 9, 2024

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @DarkLight1337.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@mergify mergify bot added the needs-rebase label Nov 9, 2024
@mergify mergify bot removed the needs-rebase label Nov 9, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@youkaichao youkaichao merged commit 51c2e1f into main Nov 9, 2024
69 of 70 checks passed
@youkaichao youkaichao deleted the shard-models-tests branch November 9, 2024 19:39
@youkaichao
Copy link
Member

I merged it to fix the test on main ASAP. also left some comments.

self.language_model = PersimmonForCausalLM(config.text_config,
cache_config=cache_config,
quant_config=quant_config)
self.language_model = PersimmonForCausalLM(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be better if this can use init_vllm_registered_model .

I think this config.text_config misses an architectures field. we can manually add the field, and then call init_vllm_registered_model.

we also need to change the signature of init_vllm_registered_model in the future.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has model_type defined so it should still be possible to match if we add this model to the registry.

Comment on lines +2082 to +2086
def with_hf_config(self, hf_config: PretrainedConfig) -> "VllmConfig":
model_config = copy.deepcopy(self.model_config)
model_config.hf_config = hf_config

return replace(self, model_config=model_config)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should flatten VllmConfig in the future, hf_config can be the same level as model_config . and we can have a top-level function vllm_config.replace_with(hf_config=hf_config)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some values in model_config depend on the hf_config, so it might be better to just have a convenience property to access hf_config directly from VllmConfig, instead of changing the nested structure.

omer-dayan pushed a commit to omer-dayan/vllm that referenced this pull request Nov 10, 2024
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Jee Jee Li <[email protected]>
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: DarkLight1337 <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants