Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model][OpenVINO] Fix regressions from #8346 #10045

Merged
merged 2 commits into from
Nov 6, 2024
Merged

[Model][OpenVINO] Fix regressions from #8346 #10045

merged 2 commits into from
Nov 6, 2024

Conversation

petersalas
Copy link
Contributor

@petersalas petersalas commented Nov 5, 2024 •
edited
Loading

Fix #10025 by adding placeholder index maps to OpenVINOAttentionMetadata.
Fix #10042 by returning DummyData instead of a tuple.

(As per the comment that I copied from AttentionMetadata, this doesn't really belong here and should probably be on ModelInputs instead, but I didn't want to diverge the OpenVINO/non-OpenVINO paths further.)

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 5, 2024
@DarkLight1337
Copy link
Member

DarkLight1337 commented Nov 5, 2024 •
edited
Loading

Thanks for the quick fix! Can you also fix the dummy data for Molmo in this PR? It is reported by #10042.

@DarkLight1337
Copy link
Member

I'm heading off soon. @ywang96 can you help with this?

@petersalas
[Model] Fix Molmo dummy data
0d3cff7 
Signed-off-by: Peter Salas <[email protected]>
@petersalas petersalas changed the title [OpenVINO] Fix regression from #8346 [Model][OpenVINO] Fix regressions from #8346 Nov 5, 2024
@petersalas
Copy link
Contributor Author

Thanks for the quick fix! Can you also fix the dummy data for Molmo in this PR? It is reported by #10042.

Done!

@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 5, 2024
@DarkLight1337
Copy link
Member

To save CI costs, I've cancelled fastcheck CI - only AWS CI has to pass for the PR to be eligible for merge.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 6, 2024 03:22
@DarkLight1337 DarkLight1337 merged commit ffc0f2b into vllm-project:main Nov 6, 2024
64 of 67 checks passed
flaviabeo added a commit to flaviabeo/vllm that referenced this pull request Nov 6, 2024
@flaviabeo
Revert "[Model][OpenVINO] Fix regressions from vllm-project#8346 (vll…
bf80f0b 
…m-project#10045)"

This reverts commit ffc0f2b.
JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
@petersalas @JC1DA
[Model][OpenVINO] Fix regressions from vllm-project#8346 (vllm-projec…
b21585a 
…t#10045)

Signed-off-by: Peter Salas <[email protected]>
Signed-off-by: Loc Huynh <[email protected]>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
@petersalas @sumitd2
[Model][OpenVINO] Fix regressions from vllm-project#8346 (vllm-projec…
4edbd2f 
…t#10045)

Signed-off-by: Peter Salas <[email protected]>
Signed-off-by: Sumit Dubey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

Assignees
No one assigned
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
2 participants
@petersalas @DarkLight1337