Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.4.3 Release Tracker #4895

Closed
2 of 6 tasks
simon-mo opened this issue May 18, 2024 · 16 comments
Closed
2 of 6 tasks

v0.4.3 Release Tracker #4895

simon-mo opened this issue May 18, 2024 · 16 comments
Labels
release Related to new version release

Comments

@simon-mo
Copy link
Collaborator

simon-mo commented May 18, 2024

ETA May 30 (due to some blockers and US holiday).

Blockers

Nice to have

@simon-mo simon-mo added the release Related to new version release label May 18, 2024
@sasha0552
Copy link
Contributor

@simon-mo
Copy link
Collaborator Author

Thanks for bring these up @sasha0552!

#4167 is unlikely to be finished in time.
#4409 might need a little bit more discussion given what features are supported for Pascal GPUs and whether building from source might be a better option.
#4638 can be included if it gets merged in time.

We do commit to biweekly release cadence so don't worry many of these will get into soon enough!

@robertgshaw2-neuralmagic
Copy link
Collaborator

Thanks for bring these up @sasha0552!

#4167 is unlikely to be finished in time. #4409 might need a little bit more discussion given what features are supported for Pascal GPUs and whether building from source might be a better option. #4638 can be included if it gets merged in time.

We do commit to biweekly release cadence so don't worry many of these will get into soon enough!

re: #4409 --> I did not have any issues running an fp16 model on a P40 when I installed from source.

@robertgshaw2-neuralmagic
Copy link
Collaborator

robertgshaw2-neuralmagic commented May 19, 2024

I am going to try to get these in

probably will not make it but tracking to v0.4.4:

@simon-mo simon-mo pinned this issue May 21, 2024
@njhill
Copy link
Member

njhill commented May 22, 2024

Sounds like we may want to include #4894 @rkooo567?

@rkooo567
Copy link
Collaborator

Yeah +1 on that PR @njhill

@robertgshaw2-neuralmagic
Copy link
Collaborator

robertgshaw2-neuralmagic commented May 23, 2024

@jasonacox
Copy link
Contributor

re: #4409 --> I did not have any issues running an fp16 model on a P40 when I installed from source.

Hi @robertgshaw2-neuralmagic - was this without the patch? I couldn't get a source build to run on P100's without the patch of #4409. With the patch, like you, running fp16 models (Mistral 7B for example) with no issues.

@sasha0552
Copy link
Contributor

With the patch, like you, running fp16 models (Mistral 7B for example) with no issues.

Not only fp16, but AQLM works well too (#5058)

image

@robertgshaw2-neuralmagic
Copy link
Collaborator

re: #4409 --> I did not have any issues running an fp16 model on a P40 when I installed from source.

Hi @robertgshaw2-neuralmagic - was this without the patch? I couldn't get a source build to run on P100's without the patch of #4409. With the patch, like you, running fp16 models (Mistral 7B for example) with no issues.

P40 requires building with the patch.

@vrdn-23
Copy link
Contributor

vrdn-23 commented May 28, 2024

Is there any particular PR that we're waiting for before cutting the release?

@robertgshaw2-neuralmagic
Copy link
Collaborator

Is there any particular PR that we're waiting for before cutting the release?

The model support for Phi and Deepseek

@AmazDeng
Copy link

AmazDeng commented Jun 1, 2024

Is there any particular PR that we're waiting for before cutting the release?

The model support for Phi and Deepseek

Excuse me, when will VLLM support embedding input?

@dongxiaolong
Copy link

Could we include #4109 ? Structured output is also very important, and it seems almost complete. @simon-mo

Link to PR #4109

@LSC527
Copy link

LSC527 commented Jun 3, 2024

Is there any particular PR that we're waiting for before cutting the release?

The model support for Phi and Deepseek

Hi, is Deepseek v2 supported now?

@simon-mo
Copy link
Collaborator Author

simon-mo commented Jun 3, 2024

Moving Deepseek to optional in #5224
Tracking #4109 as optional in #5224

@simon-mo simon-mo closed this as completed Jun 3, 2024
@simon-mo simon-mo unpinned this issue Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to new version release
Projects
None yet
Development

No branches or pull requests

10 participants