Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: During streaming tokens should not be emitted if they could form a stop sequence #3574

Closed
yunfeng-scale opened this issue Mar 22, 2024 · 1 comment · Fixed by #3672
Labels
bug Something isn't working

Comments

@yunfeng-scale
Copy link
Contributor

Your current environment

The output of `python collect_env.py`

🐛 Describe the bug

Using mistral 7b, prompt Here is the English alphabet: ABC, temperature 0, stop sequence DEFGHIJ, during streaming, DEF, G, HI tokens are output (J triggers the stop). Expected behavior is no output. Tokens should be buffered when they could form prefix of any stop sequences, and sent out when that condition is cleared.

@yunfeng-scale yunfeng-scale added the bug Something isn't working label Mar 22, 2024
@njhill
Copy link
Member

njhill commented Mar 23, 2024

@yunfeng-scale I'm currently also already working on a fix for this as part of the same set of changes mentioned in #3572.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants