Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Should check whether stop sequence appears anyway in the output text instead of just endswith #3572

Closed
yunfeng-scale opened this issue Mar 22, 2024 · 1 comment · Fixed by #3672
Labels
bug Something isn't working

Comments

@yunfeng-scale
Copy link
Contributor

Your current environment

The output of `python collect_env.py`

🐛 Describe the bug

Using mistral-7b-instruct model, and prompt Here is the English alphabet: ABC, temperature 0, stop sequence DE, model would still output DEFGHIJKLMNOPQRSTUVWXYZ... this is because DEF is a token, and stop sequence is only checked with endswith https://github.com/vllm-project/vllm/blob/main/vllm/engine/llm_engine.py#L717 I think instead of we should check string contain.

@yunfeng-scale yunfeng-scale added the bug Something isn't working label Mar 22, 2024
@njhill
Copy link
Member

njhill commented Mar 22, 2024

@yunfeng-scale yes this is definitely a bug, I'm working on a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants