leave a todo for __del__

vllm-project · Mar 27, 2024 · 6d18496 · 6d18496
1 parent 0361127
commit 6d18496
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/vllm/worker/model_runner.py b/vllm/worker/model_runner.py
@@ -850,6 +850,8 @@ def __del__(self) -> None:
         # NOTE(woosuk): This is necessary because otherwise deadlocks can
         # happen.
         # FIXME(woosuk): This is a bit hacky. Find a more robust solution.
+        # TODO(youkaichao): when we get enough user feedback that pynccl is
+        # more stable than cupy, we can remove this, e.g. in v0.4.1.
         self.graph_runners.clear()
         self.pynccl_backend = None