[8/n][pipeline-gen] Add method to generate build step #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
khluu
commented
Oct 22, 2024
•
khluu
commented
- Add method to generate build step based on commit, container registry and image.
Signed-off-by: kevin <[email protected]>
|
is this for review? could you add a PR description maybe? |
aslonnie
reviewed
Oct 22, 2024
| @@ -0,0 +1,26 @@ | |||
| from typing import List | |||
|
|
|||
| def get_build_commands(container_registry: str, buildkite_commit: str, container_image: str) -> List[str]: | |||
There was a problem hiding this comment.
any unit test? or is this so simple that does not require one?
maybe we should have some form of integration test to test these commands.
There was a problem hiding this comment.
It's just replacing placeholders for container registry, container image, and commit so I don't think unit test is needed here.
aslonnie
reviewed
Oct 22, 2024
| f"--build-arg USE_SCCACHE=1 " | ||
| f"--tag {container_image} " | ||
| f"--target test " | ||
| f"--progress plain ." |
There was a problem hiding this comment.
could you leave a todo here to not using . to include everything as the build context?
aslonnie
approved these changes
Oct 22, 2024
Signed-off-by: kevin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.