Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1/n][pipeline-gen] Add default test commands #37

Merged
merged 2 commits into from
Sep 30, 2024
Merged

[1/n][pipeline-gen] Add default test commands #37

merged 2 commits into from
Sep 30, 2024

Conversation

khluu
Copy link
Collaborator

@khluu khluu commented Sep 28, 2024

  • Add default commands that run on every test
  • Return 1xL4 queue if there's no num_gpus specified

@khluu
p
da56e58 
Signed-off-by: kevin <[email protected]>
@khluu khluu requested a review from aslonnie September 28, 2024 00:16
aslonnie
aslonnie approved these changes Sep 28, 2024
View reviewed changes
scripts/pipeline_generator/utils.py Outdated
@@ -15,6 +15,12 @@
PIPELINE_FILE_PATH = ".buildkite/pipeline.yaml"
MULTI_NODE_TEST_SCRIPT = ".buildkite/run-multi-node-test.sh"

TEST_DEFAULT_COMMANDS = [
"(command nvidia-smi || true)",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a comment that explains what does this nvidia-smi || true need to be here? it will always pass, so why check?

@khluu
P
4dc3667 
Signed-off-by: kevin <[email protected]>
@khluu khluu merged commit d4efddc into main Sep 30, 2024
1 check passed
@khluu khluu deleted the fix_utils branch October 9, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslonnie aslonnie aslonnie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khluu @aslonnie