replace interpolated text with [innerText] #274
Conversation
|
The question is why it solves it. Please open an issue. And submit your PR to the next branch |
|
@chrxs, I would like also to see how other date pickers are behaving in such examples. Please provide some examples. |
|
Hi @vlio20 I have created an issue #277 where I've written all the details of the issue, and screen capture. I haven't seen or used any other date pickers, and don't have time to see if they behave the same. <div>{{value}}</div>to: <div [innerText]="value"></div>It has resolved the issue with no side effects |
| @@ -183,11 +183,11 @@ describe('dpDayPicker dayPicker', () => { | |||
|
|
|||
| it('should check the first day of the week', () => { | |||
| page.dayPickerInput.click(); | |||
| expect(page.weekDayNames.getText()).toEqual(['Sun Mon Tue Wed Thu Fri Sat']); | |||
| expect(page.weekDayNames.getText()).toEqual(['SunMonTueWedThuFriSat']); | |||
There was a problem hiding this comment.
why did it effect this? why the spaces are gone?
There was a problem hiding this comment.
it seems there was whitespace inside the tags before, like:
<span>
November
</span>which now becomes:
<span>November</span>
|
@chrxs, you should make the PR from and to the |
We have an issue where the date picker is translated to german, but then the users browser gives them the option to translate the page. when the user does this and translates the page text values (month name for example) no long updates. Using [innerText] solves this.
We have an issue where the date picker is translated to german, but then the users browser gives them the option to translate the page. when the user does this and translates the page text values (month name for example) no long updates.
Using [innerText] solves this.
From this StackOverflow answer it seems