Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Geode to 1.13.2 #17

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,12 @@
<dependency>
<groupId>org.apache.geode</groupId>
<artifactId>geode-core</artifactId>
<version>1.9.0</version>
<version>1.13.2</version>
</dependency>
<dependency>
<groupId>org.apache.geode</groupId>
<artifactId>geode-dunit</artifactId>
<version>1.9.0</version>
<version>1.13.2</version>
<scope>test</scope>
</dependency>
</dependencies>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
import org.apache.geode.cache.Region;
import org.apache.geode.cache.execute.FunctionService;
import org.apache.geode.cache.execute.ResultCollector;
import org.apache.logging.log4j.util.Strings;

import java.util.*;
/**
Expand Down Expand Up @@ -49,7 +48,7 @@ public LongIDGenerator(final Long allocationSize) {

public LongIDGenerator(final String sequenceRegionPath, final Long allocationSize) {
super();
if (Strings.isBlank(sequenceRegionPath))
if (isBlank(sequenceRegionPath))
throw new IllegalArgumentException("sequenceRegionPath is required");
this.sequenceRegionPath = sequenceRegionPath;
if (allocationSize == null)
Expand All @@ -58,6 +57,10 @@ public LongIDGenerator(final String sequenceRegionPath, final Long allocationSiz
this.allocationSize = allocationSize;
this.allocationsByName = new HashMap<>();
}

boolean isBlank(String string) {
return string == null || string.isEmpty();
}

/**
* Return the number of identifiers that will be returned by
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ public class GeodeObjectStoreIT {
private GeodeObjectStoreDelegate storeDelegate;

@Test
@Ignore
public void testThatObjectStoreInsertsOneAndQueries() throws Exception {
dispatcher.afterCompleting(1);
final MockPersistResultInterest persistInterest = new MockPersistResultInterest();
Expand Down Expand Up @@ -123,7 +122,6 @@ public void testThatObjectStoreInsertsOneAndQueries() throws Exception {
}

@Test
@Ignore
public void testThatObjectStoreInsertsMultipleAndQueries() throws Exception {
dispatcher.afterCompleting(3);
final MockPersistResultInterest persistInterest = new MockPersistResultInterest();
Expand Down Expand Up @@ -166,7 +164,6 @@ public void testThatObjectStoreInsertsMultipleAndQueries() throws Exception {
}

@Test
@Ignore
public void testThatSingleEntityUpdates() throws Exception {
dispatcher.afterCompleting(1);
final MockPersistResultInterest persistInterest = new MockPersistResultInterest();
Expand Down Expand Up @@ -235,7 +232,6 @@ public void testThatSingleEntityUpdates() throws Exception {
}

@Test
@Ignore
public void testThatMultipleEntitiesUpdate() throws Exception {
dispatcher.afterCompleting(5);
final MockPersistResultInterest persistInterest = new MockPersistResultInterest();
Expand Down Expand Up @@ -334,7 +330,6 @@ public void testThatMultipleEntitiesUpdate() throws Exception {
}

@Test
@Ignore
public void testRedispatch() throws Exception {
final AccessSafely accessDispatcher = dispatcher.afterCompleting(5);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@
* LongIDGeneratorIT
*/
@SuppressWarnings("unchecked")
@Ignore
public class LongIDGeneratorIT {

private static final Logger LOG = LoggerFactory.getLogger(LongIDGeneratorIT.class);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@
/**
* GemFireStateStoreTest is responsible for testing {@link GeodeStateStoreActor}.
*/
@Ignore
public class GeodeStateStoreActorIT {
private static final Logger LOG = LoggerFactory.getLogger(GeodeStateStoreActorIT.class);
private final static String StoreName = Entity1.class.getSimpleName();
Expand Down