Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests] fix analyzer test #92

Merged
merged 1 commit into from
Apr 11, 2024
Merged

[tests] fix analyzer test #92

merged 1 commit into from
Apr 11, 2024

Conversation

Lycs-D
Copy link
Contributor

@Lycs-D Lycs-D commented Apr 11, 2024

  • Fix invalid tests

Copy link
Member

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible that you are using a wrong version of the code base / have conflicting local changes?

Edit: Had just 2 changed files at time of the review. Now I have the renamed ones 👍

src/tests/bench.v Show resolved Hide resolved
Copy link
Member

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it is to fix parsing issues when running V fmt over the test files with invalid code. As the tests itself should be valid.

We had the similar changes in #53. Reverting the changes in #74 a test was added that should cover the regression that it produced. So it might work now with latest V and the updated project structure. I'd check with a fresh mind after getting some sleep.

In general this looks good to me. Thank you!

@ttytm ttytm merged commit 7828291 into vlang:main Apr 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants