Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add .vsix artifacts to release asset uploads #47

Merged
merged 4 commits into from
Mar 22, 2024
Merged

[CI] Add .vsix artifacts to release asset uploads #47

merged 4 commits into from
Mar 22, 2024

Conversation

Lycs-D
Copy link
Contributor

@Lycs-D Lycs-D commented Mar 21, 2024

Fixed #15

@Lycs-D
Copy link
Contributor Author

Lycs-D commented Mar 21, 2024

Testd by https://github.com/Lycs-D/v-analyzer/actions/runs/8368163744

@JalonSolov
Copy link

I don't see the .vsix file in the artifacts on the link shown. Everything there is a .zip file.

@Lycs-D
Copy link
Contributor Author

Lycs-D commented Mar 21, 2024 •
edited
Loading

I don't see the .vsix file in the artifacts on the link shown. Everything there is a .zip file.

https://github.com/Lycs-D/v-analyzer/releases
image

@ttytm
Copy link
Member

ttytm commented Mar 21, 2024

Good work. Please resolve the conflicts with the latest release workflow changes. The workflow now also includes uploads for regular release versions.

@ttytm ttytm changed the title [CI] Add miss works [CI] Add .vsix artifacts to release asset uploads Mar 21, 2024
@ttytm ttytm added this to the 0.0.5 milestone Mar 21, 2024
@ttytm
Copy link
Member

ttytm commented Mar 22, 2024

Gonna look into the PRs soon. Sorry, about the delay.

ttytm
ttytm approved these changes Mar 22, 2024
View reviewed changes
Copy link
Member

@ttytm ttytm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job 💪 Thank you!

@ttytm ttytm merged commit a50fc40 into vlang:main Mar 22, 2024
@Lycs-D Lycs-D deleted the release_ci branch March 22, 2024 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttytm ttytm ttytm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.5
Development

Successfully merging this pull request may close these issues.

.vsix is not regenerated with other assests
3 participants
@Lycs-D @JalonSolov @ttytm