-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: fix for Neovim LSP/Mason #122
Conversation
lcheylus
commented
Sep 19, 2024
•
edited
Loading
edited
- add URL for mason registry
- add URL for mason-lspconfig.nvim plugin (':LspInstall' command)
- add URL for mason.nvim plugin (':MasonInstall v_analyzer' command)
Thanks for pointing that out. Last time checked, it was installable with lspconfig. If it isn't anymore, a fix should be submitted upstream imho. The LspInstall command is more commonly used for language servers and MasonInstall works then inherently |
There is no I don't know how you were able to run it ?!?! |
Can we keep both? note: personally I do not use neovim, so it may not make sense at all, in which case, tell me to shut up. |
No, reference to |
14ab9a0
to
8d063c4
Compare
Yep it's true what you are saying for default lspconfig. I'm referring to mason-lspconfig |
https://github.com/williamboman/mason.nvim?tab=readme-ov-file#how-to-use-installed-packages also lists mason-lspconfig to use it for lsp installation, so i'd argue it's more ideomatic in the eco system. |
Weighing up the options and beeing over pedantic: Edit: please don't mind the spelling issues, I'm having accessibility issues on my phone here 😅 |
OK, I finally understood the error in README for Neovim configuration: I will modify my PR to keep the both methods for installation:
|
- add URL for mason registry - add URL for mason-lspconfig.nvim plugin (':LspInstall' command) - add URL for mason.nvim plugin (':MasonInstall v_analyzer' command) Signed-off-by: Laurent Cheylus <[email protected]>
8d063c4
to
d4354ae
Compare
Fix my PR:
|
I just see we already have both commands (I only addressed the commonts on my phone yesterday without checking the diff). In my memory it was just Clarifying the current commands is fine 👍 |
Is it good to merge as it is now? |
Yes :) |