ci+docs: workflow cosmetics

vladopajic · Nov 22, 2024 · 4540b9b · 4540b9b
1 parent 97dd903
commit 4540b9b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 15 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -71,7 +71,15 @@ jobs:
           git-token: ${{ github.ref_name == 'main' && secrets.GITHUB_TOKEN || '' }}
           breakdown-file-name: ${{ github.ref_name == 'main' && 'main.breakdown' || '' }}
           diff-base-breakdown-file-name: ${{ steps.download-main-breakdown.outputs.found_artifact && 'main.breakdown' || '' }}
-
+
+      - name: upload artifact (main.breakdown)
+        uses: actions/upload-artifact@v4
+        if: github.ref_name == 'main'
+        with:
+          name: main.breakdown
+          path: main.breakdown
+          if-no-files-found: error
+
       # Post coverage report as comment
       - name: find pull request ID
         run: |
@@ -99,22 +107,13 @@ jobs:
           token: ${{ secrets.GITHUB_TOKEN }}
           issue-number: ${{ env.pull_request_id }}
           comment-id: ${{ steps.fc.outputs.comment-id }}
+          edit-mode: replace
           body: |
             go-test-coverage report:
             ```
-            ${{ fromJSON(steps.coverage.outputs.report) }}
-            ```
-          edit-mode: replace
+            ${{ fromJSON(steps.coverage.outputs.report) }}```
       
       - name: "finally check coverage"
         if: steps.coverage.outcome == 'failure'
         shell: bash
         run: echo "coverage check failed" && exit 1
-
-      - name: upload artifact (main.breakdown)
-        uses: actions/upload-artifact@v4
-        if: github.ref_name == 'main'
-        with:
-          name: main.breakdown
-          path: main.breakdown
-          if-no-files-found: error
diff --git a/docs/github_action.md b/docs/github_action.md
@@ -69,6 +69,7 @@ Example of report that includes coverage difference is [this PR](https://github.
       branch: main
       workflow_conclusion: success
       name: main.breakdown
+      if_no_artifact_found: warn
 
   - name: check test coverage
     uses: vladopajic/go-test-coverage@v2
@@ -135,12 +136,11 @@ Example of report is in [this PR](https://github.com/vladopajic/go-test-coverage
       token: ${{ secrets.GITHUB_TOKEN }}
       issue-number: ${{ env.pull_request_id }}
       comment-id: ${{ steps.fc.outputs.comment-id }}
+      edit-mode: replace
       body: |
         go-test-coverage report:
         ```
-        ${{ fromJSON(steps.coverage.outputs.report) }} 
-        ```
-      edit-mode: replace
+        ${{ fromJSON(steps.coverage.outputs.report) }} ```
 
   - name: "finally check coverage"
     if: steps.coverage.outcome == 'failure'