Dark title bar on macOS + matching sidebar

[ylluminate]

Other macOS Electron apps have had an issue with having a light app title bar like ElectronMail is having presently:

Other apps such as Mattermost have now resolved this through Electron updates:
mattermost/desktop#848

In addition to this, it would be nice to change the left bar's color scheme to match the dark/light mode of the OS. Perhaps leaving it the way it is by default for when the OS is in light mode, but then when in dark mode, it would be nice to change the left side panel to a darker gray and black mode to match the OS.

[vladimiry]

@ylluminate, the first point should be easy to enable if @electron got the feature supported. The only issue is that I won't be able to test the feature in the near future so will ask you to do so.

The second point will cause adding custom macOS related code since at the moment detecting the dark/light mode toggling in @electron is only supported for macOS. I would prefer to avoid adding such code but have not decided yet. Although I see that https://electronjs.org/docs/api/native-theme stuff got supported, it worth looking into it as it's supported for all systems since depends on chromium mechanisms.

[ylluminate]

Be happy to test. Also - honestly - even in light mode, making the left side bar dark by default wouldn't hurt aesthetics at all and would be better to default to dark for such a drawer / sidebar mechanism since it's mostly out of the way and does not need focus even in light mode.

@ylluminarious I'm sure you'd be happy to test as well.

[vladimiry]

Currently used left bar's color was chosen as a compromise between Protonmail's dark-ish colors and Tuatnota's light colors as the app supported both providers. But Tutanota support gt dropped with v4.0.0 and so I agree that it won't hurt to darken the color of the left bar.

[vladimiry]

https://electronjs.org/docs/api/native-theme support is added since @electron v7. The app currently uses v6 and the goal is to switch to v8 bypassing the v7. The switch is currently blocked by several upstream / @electron issues.

[ylluminate]

😢 So so sad. 😞

[vladimiry]

Besides we will probably need to switch to Protonmail v4 to enable dark mode support in the app (like at least left bar's color toggling) since v3 doesn't seem to be very darky.

[vladimiry]

Meanwhile, if you hate the left/top bar color so much and you use only one account you could try hiding that bar by hitting F12 or via the general app settings, see #128 (the feature enabled since v3.6.0).

[vladimiry]

@ylluminate can you try the dark title bar thing enabled with pre-v4 release?

FYI: this version also removes Tutanota accounts from the app settings:

• Drop Tutanota support (Drop Tutanota support #180, 1103391, 2459f70, fd3a74e, 3676cb2, edac158, d29d454). The following actions will be performed when the app starts:
  • Removing Tutanota accounts from the app settings.
  • Backing up the original settings.bin file (see file purpose in FAQ or in Readme).
  • Showing similar to the following notification:
    

[ylluminate]

Excellent, dark titlebar is good and I'm detecting no problems @vladimiry. IDEA: you could allow left sidebar / drawer customization by users like the notification colors. This way we could simply plug in our own colors to our pleasure and save yourself from implementation of mode switching logic.

[vladimiry]

@ylluminate please indicate if the issue got resolved in 4.2.0.

[ylluminate]

@vladimiry this is looking much better, thank you! 🚀

Dropdown still white on the gear down arrow, but you're doing great here. Ultimately ProtonMail itself needs to get full on dark themes working since it's still pretty clunky.