Feature/integration #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: abasatwar <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
Signed-off-by: Vishal Kushwah <[email protected]>
spattnaik
requested changes
Oct 12, 2022
dashboards-observability/common/constants/application_analytics.ts
Outdated
Show resolved
Hide resolved
| import store from '../framework/redux/store'; | ||
| import { AppPluginStartDependencies } from '../types'; | ||
| // import { Home as ApplicationAnalyticsHome } from './integrations/plugins/application_analytics/home'; |
There was a problem hiding this comment.
Remove if not necessary
| @@ -66,16 +68,23 @@ export function AppTable(props: AppTableProps) { | |||
| const [isActionsPopoverOpen, setIsActionsPopoverOpen] = useState(false); | |||
| const [modalLayout, setModalLayout] = useState(<EuiOverlayMask />); | |||
| const [selectedApplications, setSelectedApplications] = useState<ApplicationType[]>([]); | |||
| const createButtonText = 'Create application'; | |||
| const createButtonText = appType === INTEGRATION ? 'Add Integration' : 'Create application'; | |||
There was a problem hiding this comment.
As mentioned in one of the earlier comments, having an enum for applicationType would have helped here.
| @@ -66,6 +74,8 @@ import { ServiceDetailFlyout } from './flyout_components/service_detail_flyout'; | |||
| import { SpanDetailFlyout } from '../../../../public/components/trace_analytics/components/traces/span_detail_flyout'; | |||
| import { TraceDetailFlyout } from './flyout_components/trace_detail_flyout'; | |||
| import { fetchAppById, initializeTabData } from '../helpers/utils'; | |||
| import { NginxTab } from '../../integrations/plugins/nginx'; | |||
There was a problem hiding this comment.
To make things dynamic, I would like to see a list of plugins/integrations in a file. I will import that list and be done with that. I will not import each integration plugin one by one.
| }, | ||
| ]; | ||
|
|
||
| const getNginxTab = (tabId: string) => { |
There was a problem hiding this comment.
Why should the getNginxTab method be inside application.tsx file. This should have been present inside the index file of nginx integration.
dashboards-observability/public/components/application_analytics/components/create.tsx
Outdated
Show resolved
Hide resolved
...boards-observability/public/components/custom_panels/panel_modules/panel_grid/panel_grid.tsx
Outdated
Show resolved
Hide resolved
| <EuiFlexGrid columns={2} direction="column"> | ||
| {panelVisualizations.map((panelVisualization: VisualizationType, index) => ( | ||
| <EuiFlexItem> | ||
| <div className="height" key={panelVisualization.id}> |
There was a problem hiding this comment.
There is no requirement for this key property here.
Signed-off-by: Vishal Kushwah <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.