fix(analytics): ts logEvent params arg should be optional (invertase#…

…2822) * Fix analytics log event params not optional when it should be * Update Flow analytics log event type not in sync
vixtech · Nov 25, 2019 · 2e0547c · 2e0547c
1 parent a4070eb
commit 2e0547c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/index.d.ts b/lib/index.d.ts
@@ -670,7 +670,7 @@ export namespace FirebaseAnalyticsTypes {
      * @param name Event name must not conflict with any Reserved Events.
      * @param params Parameters to be sent and displayed with the event.
      */
-    logEvent(name: string, params: { [key: string]: string | number | boolean }): Promise<void>;
+    logEvent(name: string, params?: { [key: string]: string | number | boolean } | {} ): Promise<void>;
 
     /**
      * If true, allows the device to collect analytical data and send it to

diff --git a/lib/index.js.flow b/lib/index.js.flow
@@ -623,7 +623,7 @@ export interface Module extends ReactNativeFirebaseModule {
    * @param name Event name must not conflict with any Reserved Events. 100 characters is the maximum length for param key names.
    * @param params Parameters to be sent and displayed with the event.
    */
-  logEvent(name: string, params: { [key: string]: string }): Promise<void>;
+  logEvent(name: string, params?: { [key: string]: string  | number | boolean } | {}): Promise<void>;
 
   /**
    * If true, allows the device to collect analytical data and send it to Firebase.