readMemString() Wide Bugfix #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ered part of the terminator instead of the last character with unittests
rakuy0
reviewed
Aug 9, 2024
| @@ -739,6 +739,10 @@ def readMemString(self, va, maxlen=0xfffffff, wide=False): | |||
|
|
|||
| # now find the end of the string based on either \x00, maxlen, or end of map | |||
| end = mbytes.find(terminator, offset) | |||
| while (end > offset) and (end-offset) % len(terminator) != 0: | |||
| # with codepage 0, we really need \0\0\0 because the first | |||
There was a problem hiding this comment.
is this fix unique to codepage 0?
I don't have any issues with this as-is, but your comment here gives me pause.
There was a problem hiding this comment.
yes. this only affects codepage 0. non-cp0 wide strings don't trigger the double-NULL early.
if you have suggestions on how to make it better, let's talk... or even just questions that might lead us to a better answer, i'm down for a videochat soon (as soon as i kick this defconCrud)
rakuy0
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug in readMemString(<>, wide=True) where the last \x00 is considered part of the terminator instead of the last character
with unittests