Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: handle child processes #3

Merged
merged 11 commits into from
Apr 21, 2022
Merged

Conversation

Fabian-Fynn
Copy link
Collaborator

Now correctly shuts down all child processes
Also adds readme with installation and usage info

@Fabian-Fynn Fabian-Fynn self-assigned this Feb 22, 2022

```console
$ npm install
$ npm run build
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect installation instructions here, how I can use dev-pm in a project. Not how to develop dev-pm itself (that would be a different section)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it works at the moment
When Alex published the npm package we can add the required instructions

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated

```json
...
"dev": "dotenv -- node <path-to-dev-process-manager>/lib/index.js start pm.config.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only want to run dev-pm start

  • config file should not be required (or optional)
  • dotenv is application specific (not required in docs)
  • dev-pm should install a bin file

Copy link
Collaborator Author

@Fabian-Fynn Fabian-Fynn Apr 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Alex said he would do the creation of the bin file as part of the publishing to npm
This will allow running it with dev-pm start
I can make the config file optional but then it could only run one script from one package.json
I removed dotenv from the example

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Alex said he would do the creation of the bin file as part of the publishing to npm

ok. Do you have somewhere a todo-list for after-first-publish?

I can make the config file optional but then it could only run one script from one package.json

You can keep the option and give it a default value. I'm unsure if that is a good idea, what do others say about that?

Copy link
Collaborator Author

@Fabian-Fynn Fabian-Fynn Apr 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have somewhere a todo-list for after-first-publish?

I just created a confluence page

You can keep the option and give it a default value. I'm unsure if that is a good idea, what do others say about that?

I will check.

…_optional

Feat: Make path to config file optional
@Fabian-Fynn Fabian-Fynn merged commit a4b18cf into main Apr 21, 2022
@Fabian-Fynn Fabian-Fynn deleted the feat/handle-child-processes branch April 21, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants