Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ability to open temporary menu #279

Merged

Conversation

jamesricky
Copy link
Contributor

The temporary menu should only be toggled (closed) once, when the component is rendered for the first time.
Adding dependencies to the useEffect function would cause the menu to close immediately, eg. when the menu is opened.

@nsams
Copy link
Member

nsams commented Dec 30, 2020

ein kommentar der das erklärt wäre nicht schlecht

@jamesricky
Copy link
Contributor Author

ein kommentar der das erklärt wäre nicht schlecht

Hätte ich eh in die commit-message/mr-beschreibung geschreiben... oder is da was unklar?

@nsams
Copy link
Member

nsams commented Dec 30, 2020

ich hab gemeint kommentar im code - man schaut nicht immer gleich im git....

The temporary menu should only be toggled (closed) once, when the component is rendered for the first time.
Adding dependencies to the useEffect function would cause the menu to close immediately, eg. when the menu is opened.
@jamesricky jamesricky merged commit 077f35c into vivid-planet:master Jan 4, 2021
@jamesricky jamesricky deleted the fix-opening-temporary-menu branch January 4, 2021 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants