Add the StackMainContent component
#2754
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version of `MainContent` only adds content spacing and height when it's the last visible `StackSwitch`. Using `StackMainContent` instead of `MainContent` prevents unintended or duplicate spacings in cases where multiple `MainContent` components are used inside nested `StackSwitch` components.
jamesricky
force-pushed
the
add-stack-main-content-component
branch
from
d4e89ae
to
eadd5f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This version of
MainContentonly adds content spacing and height when it's the last visibleStackSwitch.Using
StackMainContentinstead ofMainContentprevents unintended or duplicate spacings in cases where multipleMainContentcomponents are used inside nestedStackSwitchcomponents.Example of handmade "Add Product Variant" form in demo
In this case, the form, using
MainContentfor content spacing (inside aStackSwitchandStackPage) is nested insideTabswhich are also wrapped withMainContentfor spacing around theTabs.Changeset
Related tasks and documents
https://vivid-planet.atlassian.net/browse/COM-1245
Open TODOs/questions