Use separate jwt's for invoking preview and storing preview state #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fraxachun
force-pushed
the
site-preview-jwt-expire
branch
from
0dbf222
to
e44e6f3
Compare
johnnyomair
reviewed
Oct 31, 2024
| } | ||
|
|
||
| const data = await verifySitePreviewJwt(jwt); | ||
| if (!data) { | ||
| return NextResponse.json({ error: "JWT-validation failed." }); |
There was a problem hiding this comment.
Should this return a 200 status code?
| @@ -11,10 +11,13 @@ async function legacyPagesRouterSitePreviewApiHandler( | |||
| const jwt = params.jwt; | |||
|
|
|||
| if (typeof jwt !== "string") { | |||
| throw new Error("Missing jwt parameter"); | |||
| return res.end("JWT-Parameter is missing."); | |||
There was a problem hiding this comment.
This should probably be 400 bad request
There was a problem hiding this comment.
HTTP 401 Unauthorized would also be an option
There was a problem hiding this comment.
It's 400 an json now: e44e6f3
| } | ||
|
|
||
| const data = await verifySitePreviewJwt(jwt); | ||
| if (!data) { | ||
| return res.end("JWT-validation failed."); |
There was a problem hiding this comment.
This should probably be 400 bad request
johnnyomair
approved these changes
Oct 31, 2024
nsams
approved these changes
Nov 3, 2024
thomasdax98
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The JWT to invoke the site preview has to be transferred via a GET-Parameter (see Draft Mode in Next.JS). This PR shortens the validity time of this JWT to 10 seconds as the site creates a new JWT (which is not transferred via GET) for itself which stores the preview state.
Additional, do not throw a server error when JWT is not valid. This also prevents an error when the preview-state jwt is not valid anymore, it just will be ignored.
Changeset