Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent socket exhaustion in BlobStorageS3Storage #2666

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Prevent socket exhaustion in BlobStorageS3Storage #2666

merged 7 commits into from
Nov 12, 2024

Commits on Nov 6, 2024

  1. Comment env vars for testing and fix env var validation for S3 vars

    @thomasdax98
    thomasdax98 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    1d733ff View commit details
    Browse the repository at this point in the history

  2. Change return type of getPartialFile and getFile from ReadableStream … 

    …to Readable

This is non-breaking because Readable implements ReadableStream
    @thomasdax98
    thomasdax98 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5575e07 View commit details
    Browse the repository at this point in the history

  3. Prevent the API from crashing because of stream errors when deliverin… 

    …g a file
    @thomasdax98
    thomasdax98 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5cb03df View commit details
    Browse the repository at this point in the history

  4. Prevent socket exhaustion in BlobStorageS3Storage

    @thomasdax98
    thomasdax98 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a47c547 View commit details
    Browse the repository at this point in the history

  5. Uncomment S3 env variables

    @thomasdax98
    thomasdax98 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a2b6d81 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Update requestTimeout comment

    @thomasdax98
    thomasdax98 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    cfbaef5 View commit details
    Browse the repository at this point in the history

  2. Remove client disconnected debug comment

    @thomasdax98
    thomasdax98 committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    a53b9fd View commit details
    Browse the repository at this point in the history