Move Redirect handling from middleware to ...path/page and resolve them on demand #2638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…em on demand Major advantage is that we don't have to load all redirects into memory and get independent of the number of redirects. Theoretically incompatible: if a redirect and page with the same path exist, previously the redirect was used, now the page is used
nsams
force-pushed
the
redirect-move-to-page
branch
from
cf9e412
to
38074ee
Compare
nsams
commented
Oct 17, 2024
johnnyomair
reviewed
Oct 17, 2024
johnnyomair
reviewed
Oct 17, 2024
Since this is Demo-only, I wouldn't regard this as breaking. |
…or this and show good error message
johnnyomair
reviewed
Oct 21, 2024
Co-authored-by: Johannes Obermair <[email protected]>
johnnyomair
approved these changes
Oct 22, 2024
fichtnerma
pushed a commit
that referenced
this pull request
Nov 7, 2024
…e them on demand (#2638) Major advantage is that we don't have to load all redirects into memory and get independent of the number of redirects. Theoretically incompatible: if a redirect and page with the same path exist, previously the redirect was used, now the page is used. One tricky part is that redirects are not language scoped, but pages are: - for redirects I take the language param and put append it to the source path - to support redirects with "invalid" languages (from the page tree perspective) - for example `/redirect-10` I had to avoid sending an invalid `scope.language` (would be `redirect-10`) by adding the `@skip` directive - else the api responds with an Access Denied error as the scope is not allowed Co-authored-by: Johannes Obermair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major advantage is that we don't have to load all redirects into memory and get independent of the number of redirects.
Theoretically incompatible: if a redirect and page with the same path exist, previously the redirect was used, now the page is used.
One tricky part is that redirects are not language scoped, but pages are:
/redirect-10I had to avoid sending an invalidscope.language(would beredirect-10) by adding the@skipdirective - else the api responds with an Access Denied error as the scope is not allowed