-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge @comet/blocks-api
into @comet/cms-api
#2635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes reference to `@comet/blocks-api`, but isn't used anymore.
johnnyomair
force-pushed
the
COM-1120-merge-blocks-api-into-cms-api
branch
from
October 17, 2024 10:14
de00d13
to
1376d96
Compare
I've compiled a list of newly added exports to the public API: List of newly added exports
I've reviewed the list and looked for exports which are too generic. I'd therefore propose the following changes:
What do you think? Any other exports you'd like to change? |
aren't those block specific?
|
You're right, I'll rename those as well |
nsams
approved these changes
Oct 29, 2024
thomasdax98
approved these changes
Nov 9, 2024
@fraxachun do you want to review this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The dedicated
@comet/blocks-api
package was originally introduced to support projects without CMS parts.It turned out that this is never the case, so the separation doesn't make sense anymore.
Therefore, the
@comet/blocks-api
is merged into the@comet/cms-api
package.Example
Changeset
Related tasks and documents
Task: https://vivid-planet.atlassian.net/browse/COM-1120
Further information
The first commit merges the packages, the other commits add some improvements.