Demo Site: Custom Server: Improve error handling #2617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsams
commented
Oct 9, 2024
| }) | ||
| .listen(port, () => { | ||
| // eslint-disable-next-line no-console | ||
| console.log(`> Ready on http://localhost:${port}`); |
There was a problem hiding this comment.
log Ready message in callback (else it is printed before it is actually ready)
nsams
commented
Oct 9, 2024
| .catch((error) => console.error(error)); | ||
| .once("error", (err) => { | ||
| console.error(err); | ||
| process.exit(1); |
There was a problem hiding this comment.
handle error by exiting, for example when port is not available
nsams
commented
Oct 9, 2024
| }) | ||
| .catch((error) => console.error(error)); |
johnnyomair
approved these changes
Oct 9, 2024
johnnyomair
pushed a commit
to vivid-planet/comet-starter
that referenced
this pull request
Oct 15, 2024
Demo implementation: vivid-planet/comet#2595 and vivid-planet/comet#2617
fichtnerma
pushed a commit
that referenced
this pull request
Nov 7, 2024
Adapt the custom server according to the [Next docs](https://nextjs.org/docs/pages/building-your-application/configuring/custom-server).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapt to next docs https://nextjs.org/docs/pages/building-your-application/configuring/custom-server
see inline comments for the 3 changes I made (the rest is just formatting by prettier)