COM-486: Prevent XSS attacks in isLinkTarget validator
#1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
max-debug022
previously approved these changes
Mar 12, 2024
|
I know this is a bit out of scope, but could you please rename the files to the new name? This was forgotten in #1671. |
|
Also, please add a changeset. |
Sure. What should be the content of that? |
IMO it should be a patch. Maybe something like: Prevent XSS attacks in `isLinkTarget` validator |
johnnyomair
changed the title
isLinkTarget validator
johnnyomair
previously approved these changes
Mar 13, 2024
packages/api/blocks-api/src/blocks/externalLinkBlock/is-href.validator.ts
Show resolved
Hide resolved
max-debug022
approved these changes
Mar 18, 2024
johnnyomair
approved these changes
Mar 18, 2024
jomunker
added a commit
that referenced
this pull request
Mar 18, 2024
## Description This PR adds a filter for and in the function and decorator to prevent XSS attacks.
jomunker
added a commit
that referenced
this pull request
Mar 18, 2024
## Description This PR adds a filter for `javascript` and `data` in the `isLinkTarget` function and decorator to prevent XSS attacks. (cherry picked from commit 9867242)
jomunker
added a commit
that referenced
this pull request
Mar 18, 2024
## Description This PR adds a filter for `javascript` and `data` in the `isLinkTarget` function and decorator to prevent XSS attacks. (cherry picked from commit 9867242)
thomasdax98
added a commit
that referenced
this pull request
Mar 19, 2024
thomasdax98
added a commit
that referenced
this pull request
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a filter for
javascriptanddatain theisLinkTargetfunction and decorator to prevent XSS attacks.