Add the possibility to search for a path. #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide screencasts of all cases you're handling in this change |
johnnyomair
reviewed
Jul 5, 2023
|
I tested the search for a page with the name "Vivid" and the path "/planet". I encountered some strange behaviors.
3.mov
Bildschirmaufnahme.2023-07-14.um.13.51.01.mov |
max-debug022
force-pushed
the
allow-path-search-in-admin
branch
from
470393a
to
ec93446
Compare
✅ Deploy Preview for comet-dxp-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johnnyomair
reviewed
Jul 20, 2023
max-debug022
force-pushed
the
allow-path-search-in-admin
branch
from
ec93446
to
4e90001
Compare
max-debug022
force-pushed
the
allow-path-search-in-admin
branch
from
4e90001
to
e498027
Compare
|
@johnnyomair Should there be a changeset for this change? |
Yes, we also want changesets for user-facing features 🙂 |
johnnyomair
reviewed
Oct 5, 2023
max-debug022
force-pushed
the
allow-path-search-in-admin
branch
from
2bb6e22
to
e76fcd3
Compare
johnnyomair
requested changes
Oct 10, 2023
✅ Deploy Preview for comet-admin ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
johnnyomair
previously approved these changes
Oct 31, 2023
|
@max-debug022 please update the PR's description so it can be used as the commit message |
johnnyomair
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge request adds the possibility to search for page-paths.
The matches are highlighted in the same way as RegEx-Textsearch matches, which means there is possibly more than one match per page in the page search.
In addition, when searching for a path, the page-tree-row shows the matching path.
Screen.Recording.2023-07-19.at.13.31.52.mov