-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(actions): ♻️ rebuild CI build system #61
Conversation
Prettier changelog content to reader format. ref: #59
@vivaxy If there are no more suggestions for the steps, I will squash and merge the PR then test the workflow. 😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've done a great job!👍
Sorry for my curiosity. There are some questions that I am not sure why. Could you please help clarifying them?
.github/workflows/release.yml
Outdated
git config --global user.email "github-actions[bot]@users.noreply.github.com" | ||
git add . | ||
git commit -m "chore(release): :bookmark: release v${{steps.version.outputs.version}}" | ||
git push https://x-access-token:${{secrets.GITHUB_TOKEN}}@github.com/${{github.GITHUB_REPOSITORY}}.git |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to have a git tag here. Previously --skip.tag
was used in standard-version
.
The
release
workflow will run with the follow steps by trigger manually:package.json
and write change log withstandard-version
.CHANGELOG.md
and push the commit..vsix
.CHANGELOG.md
by usingmindsers/changelog-reader-action
.Other changes:
CHANGELOG.md
into.prettierignore
.deploy
for publish.version
.release
.sed 's/^### \[/## [/' -i CHANGELOG.md
to change the changelog content, because it will make content to fit the markdown rules.yarn prettier --write CHANGELOG.md --prose-wrap never --ignore-path ./gitignore
to pretty the format ofCHANGELOG.md
, and it will make content to fill correcttly with the release body.Close #59