Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(actions): 👷 add CI to build package and release #57

Merged
merged 5 commits into from
Mar 2, 2021
Merged

ci(actions): 👷 add CI to build package and release #57

merged 5 commits into from
Mar 2, 2021

Conversation

yi-Xu-0100
Copy link
Collaborator

Add CI to build package and release.

Close #56

@yi-Xu-0100 yi-Xu-0100 merged commit 8318e6a into vivaxy:master Mar 2, 2021
@yi-Xu-0100 yi-Xu-0100 deleted the build-release branch March 2, 2021 12:08
Copy link
Owner

@vivaxy vivaxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @yi-Xu-0100. Thank you for your excellent work.

@@ -103,6 +103,8 @@
"compile": "tsc -p ./",
"watch": "tsc -watch -p ./",
"release": "standard-version && vsce publish && git push --follow-tags",
"version": "standard-version && git push --follow-tags",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Where is version command used?
  • I think version in npm scripts will be triggered when npm version run. See npm pre--post-scripts. Is it intentional to do so, or not?
  • Now version is almost the same to release, is it possible to update release command to npm run version && vsce publish?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] use action to build vsix and release
2 participants