Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Settings to remove unused options #107

Closed
ahinkle opened this issue Mar 29, 2021 · 3 comments · Fixed by #111 · May be fixed by yi-Xu-0100/vscode-conventional-commits#6
Closed

[FEAT] Settings to remove unused options #107

ahinkle opened this issue Mar 29, 2021 · 3 comments · Fixed by #111 · May be fixed by yi-Xu-0100/vscode-conventional-commits#6
Assignees
Labels
enhancement New feature or request

Comments

@ahinkle
Copy link

ahinkle commented Mar 29, 2021

Is your feature request related to a problem? Please describe.
Hi, Thank you for creating this awesome extension. I've been using it for quite some time and one thing that bothers me is spamming through "enter" on sections that I never complete.

For example:

  • Type of change: chore
  • Scope: (issue number)
  • Emoji: 📝
  • short description: Update documentation
  • longer description:
  • breaking changes:

Describe the solution you'd like
It would be nice if we could have all 6 options as a setting checkbox to define if it will appear in the 1/6 commit options with each option default set to true or checked.

it looks like we have some of the options already done (Emoji and Scopes) but it would be nice for all options.

Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.

Additional context
Add any other context or screenshots about the feature request here.

@ahinkle ahinkle added the question Further information is requested label Mar 29, 2021
@yi-Xu-0100
Copy link
Collaborator

👋 @ahinkle Thanks for your suggestions, These options will add in the future if I have the time to do. 👍

  1. For the emoji and the scope, you can set the conventionalCommits.gitmoji and the conventionalCommits.promptScopes as false to disable them. This should have an introduction in the README, I will enhance this part. 📝
  2. And the breaking changes will have the configuration, too. 😁
  3. For the others, please be patient, I will do it! 🚧

By the way, if you have the time to complete those feature and make a PR, I will appreciate it! 😊

@yi-Xu-0100 yi-Xu-0100 assigned vivaxy and yi-Xu-0100 and unassigned vivaxy Mar 29, 2021
@yi-Xu-0100 yi-Xu-0100 added documentation Improvements or additions to documentation enhancement New feature or request and removed question Further information is requested documentation Improvements or additions to documentation labels Mar 29, 2021
@yi-Xu-0100
Copy link
Collaborator

yi-Xu-0100 commented Apr 2, 2021

👋@ahinkle @vivaxy, according to the specification of the conventional commits, I think the type and description should not remove. 😁

@ahinkle Reopen this issue if there are any more needs. 😊

@ahinkle
Copy link
Author

ahinkle commented Apr 2, 2021

Yes, completely agree there. Thank you so much! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment