Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] If the promptScopes changed, the context of scope will be retained #100

Closed
yi-Xu-0100 opened this issue Mar 24, 2021 · 0 comments · Fixed by #119 · May be fixed by #101
Closed

[BUG] If the promptScopes changed, the context of scope will be retained #100

yi-Xu-0100 opened this issue Mar 24, 2021 · 0 comments · Fixed by #119 · May be fixed by #101
Assignees
@yi-Xu-0100
Labels
bug Something isn't working

Comments

@yi-Xu-0100
Copy link
Collaborator

Describe the bug
If the promptScopes changed, the context of scope will be retained.

To reproduce
Steps to reproduce the behavior:

  1. Set promptScopes as true.
  2. make a commit with scope.
  3. Set promptScopes as false.
  4. make a commit and there will have the scope last used in the message.

Expected behavior

The scope should empty when the promptScopes as false.
@yi-Xu-0100 yi-Xu-0100 added the help wanted Extra attention is needed label Mar 24, 2021
@yi-Xu-0100 yi-Xu-0100 assigned vivaxy and yi-Xu-0100 and unassigned vivaxy Mar 24, 2021
@yi-Xu-0100 yi-Xu-0100 added bug Something isn't working and removed help wanted Extra attention is needed labels Mar 24, 2021
yi-Xu-0100 added a commit to yi-Xu-0100/vscode-conventional-commits that referenced this issue Mar 24, 2021
@yi-Xu-0100
fix(prompt): 🐛 fix the prompt context retaining issue
326c953 
Close vivaxy#100
@yi-Xu-0100 yi-Xu-0100 mentioned this issue Mar 24, 2021
Open
@yi-Xu-0100 yi-Xu-0100 linked a pull request Mar 24, 2021 that will close this issue
feat(breakingchange): ✨ add breaking change configuration #101
Open
@yi-Xu-0100 yi-Xu-0100 removed a link to a pull request Mar 24, 2021
feat(breakingchange): ✨ add breaking change configuration #101
Open
@yi-Xu-0100 yi-Xu-0100 mentioned this issue Apr 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yi-Xu-0100 yi-Xu-0100

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
2 participants
@vivaxy @yi-Xu-0100