-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API for object pagination, count(*) #288
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s rather than only the most representative frame.
This is required since FFMpegAudioDecoder and TechnicalVideoMetadataExtractor use Math.floorDiv, which is a function only available since Java 9.
Due to popular demand.
# Conflicts: # build.gradle # cineast-core/src/main/java/org/vitrivr/cineast/core/features/VisualTextCoEmbedding.java
# Conflicts: # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailEntityCreator.java # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailSelector.java # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailWrapper.java # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailWriter.java # cineast-core/src/test/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailIntegrationTest.java # cineast-core/src/test/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailMetadataTest.java # cineast-runtime/src/main/java/org/vitrivr/cineast/standalone/cli/CineastCli.java # cineast-runtime/src/main/java/org/vitrivr/cineast/standalone/cli/OptimizeEntitiesCommand.java # cineast-runtime/src/main/java/org/vitrivr/cineast/standalone/cli/db/LSC21TemporalUpdateCommand.java # gradle.properties
# Conflicts: # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailEntityCreator.java
# Conflicts: # cineast-core/src/main/java/org/vitrivr/cineast/core/db/cottontaildb/CottontailEntityCreator.java
lucaro
requested changes
Apr 13, 2022
...rg/vitrivr/cineast/api/rest/handlers/actions/mediaobject/FindObjectPaginationGetHandler.java
Outdated
Show resolved
Hide resolved
lucaro
previously approved these changes
Apr 22, 2022
…xtraction to not correctly resolve
lucaro
previously approved these changes
Apr 25, 2022
# Conflicts: # build.gradle # cineast-api/src/main/java/org/vitrivr/cineast/api/rest/resolvers/FileSystemThumbnailResolver.java # docs/openapi.json
Spiess
approved these changes
Apr 26, 2022
Merged
silvanheller
added a commit
that referenced
this pull request
Jun 10, 2022
Former-commit-id: a389687
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds upon #285, which is why it targets it so the diff is meaningful. It is focused on the use case of allowing a frontend to paginate through all elements in a large collection.
It adds the following features:
count/table/{table}
which is SELECT count(*) FROM table. This is needed to determine to nicely render pagination options (e.g. number of pages)find/object/all/{skip}/{limit}
which basically implements SELECT * FROM multimediaobjects SKIP skip LIMIT limit. This is used for the actual pagination.It also does the following:
APIConstants
MediaObjectReader
with the try-with-resources syntax